Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6658 Swapped extra quotes for double brackets in bibtex citation, title #6674

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

mheppler
Copy link
Contributor

What this PR does / why we need it:

Fixes bibtex dataset citation format that had quotes outside the brackets, which was deem unnecessary, and instead use double brackets to preserve capitalization, including "CamelCase" formatting.

Which issue(s) this PR closes:

Closes #6658 Quotes added to BibTeX output

Special notes for your reviewer:

Might need to confirm with researchers who are more familiar with using bibtex and latex and pdflatex.

Suggestions on how to test this:

Might need to install bibtex and latex and pdflatex in order to see citation formatting in PDF.

Does this PR introduce a user interface change?:

No.

Is there a release notes update needed for this change?:

No.

Additional documentation:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.464% when pulling 38760b0 on 6658-bibtex-citation-noquotes into 7227c38 on develop.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA Feb 24, 2020
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test anything but the code change matches the title of the pull request and I like the detailed write up at #6658 (comment) (kudos to @mheppler for the command line wizardry).

@kcondon kcondon self-assigned this Feb 26, 2020
@kcondon
Copy link
Contributor

kcondon commented Feb 26, 2020

@mheppler @pdurbin @jggautier

Update: OK, my bad, I missed the whole double brackets in title and to preserve capitalization. Instead, I saw Danny's post about the problem saying should either be braces or quotes, not both and Julians link to a formerly working output that had single braces only.

The title now has double braces. Sending back to Dev for eval.

@DaTa{FK2/XZL6QA_2020,
author = {Admin, Dataverse},
publisher = {Root},
title = {{Test BibTex Title Formatting}},
year = {2020},
version = {DRAFT VERSION},
doi = {10.70122/FK2/XZL6QA},
url = {https://doi.org/10.70122/FK2/XZL6QA}
}

@kcondon kcondon removed their assignment Feb 26, 2020
@kcondon kcondon self-assigned this Feb 26, 2020
@kcondon kcondon merged commit 8ad480b into develop Feb 26, 2020
@kcondon kcondon deleted the 6658-bibtex-citation-noquotes branch February 26, 2020 18:54
@mheppler
Copy link
Contributor Author

Double brackets around the title was intended. As I pointed out in my outline in the issue, that solution was required to preserve "CamelCase" formatting use case that was the original use case from @pameyer and the reason why the quotes were used.

@djbrooke djbrooke added this to the 4.20 milestone Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Quotes added to BibTeX output
5 participants